Skip to content

Refactor handling of list-backed arguments #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 26, 2019
Merged

Refactor handling of list-backed arguments #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1ad86a3
fix bug handling Type in Populate() overloads
jpdillingham Mar 25, 2019
e728b48
un-comment test for long and short params
jpdillingham Mar 25, 2019
647c1bb
add additional tests for short/long list population
jpdillingham Mar 25, 2019
e13e0c0
upgrade language version
jpdillingham Mar 25, 2019
f019e8b
fix bug in population of short names for mixed short/long arguments
jpdillingham Mar 25, 2019
e7e62de
add ArgumentInfo.Type and ArgumentInfo.IsCollection
jpdillingham Mar 25, 2019
24f80ce
populate Type in GetArgumentInfo
jpdillingham Mar 25, 2019
c6a0751
revert projects to C# 7.0, remove documentation for private elements,…
jpdillingham Mar 25, 2019
63bb0e1
simplify StyleCop config
jpdillingham Mar 25, 2019
b65b62f
add TargetType and ArgumentList to Arguments, add GetArgumentDictiona…
jpdillingham Mar 25, 2019
2001ef6
add tests for GetArgumentDictionary()
jpdillingham Mar 25, 2019
a4ebde5
add additional tests for typeless argument parsing
jpdillingham Mar 25, 2019
f90d924
remove deprecated GetArgumentHelp and ArgumentHelp
jpdillingham Mar 26, 2019
c974a51
revert GetArgumentDictionary()
jpdillingham Mar 26, 2019
aff4f81
refactor GetArgumentDictionary into GetArgumentList
jpdillingham Mar 26, 2019
aff5703
refactor tests to use KVP<string, string> over KVP<string, object>
jpdillingham Mar 26, 2019
e995227
make TrimOuterQuotes() an extension method
jpdillingham Mar 26, 2019
4100fdf
remove deprecated ExclusiveAdd()
jpdillingham Mar 26, 2019
d71a4df
pass arg dictionary to Arguments(), make constructor private again
jpdillingham Mar 26, 2019
b130580
use Parse() in dictionary tests
jpdillingham Mar 26, 2019
4cacf73
rename test classes
jpdillingham Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/Example/Example.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<LangVersion>7</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
349 changes: 114 additions & 235 deletions src/Utility.CommandLine.Arguments/Arguments.cs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions src/Utility.CommandLine.Arguments/Utility.CommandLine.Arguments.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<Version>2.0.0</Version>
<AssemblyVersion>2.0.1.0</AssemblyVersion>
<LangVersion>7</LangVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
Expand All @@ -17,12 +18,10 @@
</PropertyGroup>

<ItemGroup>
<None Remove="stylecop.json" />
<None Remove="stylecop.ruleset" />
</ItemGroup>

<ItemGroup>
<AdditionalFiles Include="stylecop.json" />
<AdditionalFiles Include="stylecop.ruleset" />
</ItemGroup>

Expand Down
16 changes: 0 additions & 16 deletions src/Utility.CommandLine.Arguments/stylecop.json
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions src/Utility.CommandLine.Arguments/stylecop.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,6 @@
<Rule Id="SA1124" Action="None" />
<Rule Id="SA1633" Action="None" />
<Rule Id="SA1649" Action="None" />
<Rule Id="SA1402" Action="None" />
</Rules>
</RuleSet>
Loading