-
Couldn't load subscription status.
- Fork 1
Overlay bounds #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So, it looks like it's actually placing the overlay on the "top" level, meaning blocks with only sky above? Looks like a solid approach, though I'm curious if you can adjust the opacity of the overlay? |
|
You can adjust the opacity, the last number defining the color is the alpha (ie. (r, g, b, a)) and can be set from 0-255. |
|
|
||
| /* first, chain up */ | ||
| int ret = primitive_overlay.start(data, state, support); | ||
| if (ret != 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I prefer to always wrap conditional blocks in curly brackets, but I'm not sure what the upstream project's styles (and C, generally) dictates as the standard.
|
|
||
| // opt is a borrowed reference. do not deref | ||
| // store the bounds python object into opt. | ||
| if (!render_mode_parse_option(support, "bounds", "O", &(opt))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
|
Other than those nitpicks, LGTM. Did you want me to merge this? |
|
I will fix those nitpickets first. |
|
Setup file code that generated it: |
|
LGTM! |


Added custom render mode
BoundsOverlayto overlay colors within sets of bounding boxes. An example usage in a config file would be: