Open
Conversation
openvoxdb/server have proper dependencies to java, we don't need to explicitly install it.
The kvm_automation_tooling::subplans::install_server_prerequisites plan was a work around for cases where we were installing pre-release server packages directly from downloaded rpm/deb files using rpm/dpkg. Since these commands don't handle dependencies, this plan/class handled installing dependent packages like java for openvox-server/openvoxdb. The tasks used to install the packages are from openvox_bootstrap, which was updated as of voxpupuli/puppet-openvox_bootstrap#50 to use yum/apt to install the files. Yum and apt will install the dependencies (something apt-get won't do, and something I overlooked when writing the original openvox_bootstrap::install_build_artifact task). Given that the dependencies are being handled again by the package manager, this workaround plan/class goes away.
jpartlow
force-pushed
the
migrate-to-openbolt-and-remove-prereqs
branch
from
f7b194a to
63e010f
Compare
Draft
Owner
Author
|
This works; I manually checked an install_openvox with openvox_released false for a couple of local vms on alma9, and the pre-reqs (java) were installed by yum, using your fixes to openvox_bootstrap. So I think we just need to get voxpupuli/puppet-openvox_bootstrap#50 merged, and then cleanup the bolt-project.yaml ref here and merge as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of Tim's work to update to openbolt, and bump some dependent packages, plus a commit to test out dropping the prerequisite package handling for pre-release installs of openvox-server/openvoxdb entirely.