-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move author field to languages.xx.toml under params #704
feat: move author field to languages.xx.toml under params #704
Conversation
✅ Deploy Preview for hugo-congo ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Not sure how to change the docs correctly. For snippets like this in # config/_default/languages.en.toml
title = "My awesome website"
[author]
name = "My name"
image = "img/author.jpg"
headline = "A generally awesome human"
bio = "A little bit about me"
links = [
{ twitter = "https://twitter.com/username" }
] So I just make another snippet that points is something like # config/_default/languages.en.toml
title = "My awesome website" # config/_default/params.toml
[author]
name = "My name"
image = "img/author.jpg"
headline = "A generally awesome human"
bio = "A little bit about me"
links = [
{ twitter = "https://twitter.com/username" }
] |
I think this is on the right track, but I don't think moving the author params to ie. we end up with: [params.author]
name = "Name" I haven't tackled this one yet as it's a bit of breaking change for users to migrate these values and so it needs a minor version bump. It might be valuable to test some fallback scenarios to determine if it can handle using both the values in the correct location and the old location. I also think this change could be bundled into a wider feature that implements multi-author functionality. |
Updated! Is the current implementation ok? |
That's much better, I think the only thing left to tweak is the warning message. It's directing people to the |
Thanks, looks good. I'll merge it in later today. |
hey @jpanther - thanks for maintaining this great theme! QQ: am I wrong or this fix hasn't made it yet in a released version? Sorry, I'm not sure familar with the whole Go ecosystem |
I think it is just in dev and not in a release yet |
Just upgraded to latest stable 5c8ab32 and Adding links under but then the console displays the Congo warning: Same thing with the |
First time contributing so please do let me know if I am doing something wrong.
author
field toparams.toml
author
field is inlanguages.xx.toml
instead ofparams.toml
Closes #690