Skip to content

Don't use implicit optionals #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Don't use implicit optionals #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b84cff
Turn off implicit-optional
rekyungmin Oct 22, 2021
113ff3f
Change type annotations to use explicit optional
rekyungmin Oct 22, 2021
ba0d522
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jwt/api_jws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ def decode_complete(
self,
jwt: str,
key: str = "",
algorithms: List[str] = None,
options: Dict = None,
algorithms: Optional[List[str]] = None,
options: Optional[Dict] = None,
**kwargs,
) -> Dict[str, Any]:
if options is None:
Expand Down Expand Up @@ -161,8 +161,8 @@ def decode(
self,
jwt: str,
key: str = "",
algorithms: List[str] = None,
options: Dict = None,
algorithms: Optional[List[str]] = None,
options: Optional[Dict] = None,
**kwargs,
) -> str:
decoded = self.decode_complete(jwt, key, algorithms, options, **kwargs)
Expand Down
8 changes: 4 additions & 4 deletions jwt/api_jwt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def decode_complete(
self,
jwt: str,
key: str = "",
algorithms: List[str] = None,
options: Dict = None,
algorithms: Optional[List[str]] = None,
options: Optional[Dict] = None,
**kwargs,
) -> Dict[str, Any]:
if options is None:
Expand Down Expand Up @@ -112,8 +112,8 @@ def decode(
self,
jwt: str,
key: str = "",
algorithms: List[str] = None,
options: Dict = None,
algorithms: Optional[List[str]] = None,
options: Optional[Dict] = None,
**kwargs,
) -> Dict[str, Any]:
decoded = self.decode_complete(jwt, key, algorithms, options, **kwargs)
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,4 @@ extend-ignore = E203, E501
python_version = 3.6
ignore_missing_imports = true
warn_unused_ignores = true
no_implicit_optional = true