Skip to content
This repository was archived by the owner on May 26, 2020. It is now read-only.
This repository was archived by the owner on May 26, 2020. It is now read-only.

Unreachable code when user is_active is False in. #491

Open
@tzimos

Description

@tzimos

When using the default ModelBackend in django settings activated,
the authenticate method in django.contrib.auth.backends.ModelBackend has the user_can_authenticate method.
In our case user.is_active is False and as a result the whole authenticate method in
this file returns None.
As a result in line 53 there is a check if the user is_active but it is unreachable in this point
and we render the wrong message which is in line 64.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions