prevent buffer overflow from input string#9
Open
rd-blue wants to merge 1 commit intojoy-it:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StromPI3 V1.8 crashes with a buffer overflow when input string is too long. Then no command mode is possible anymore. This can happen e.g. when used with Home Assistant which is producing some messages during boot on serial0. When survived on Home Assistant status is messed up and looks like this:
Time: 00:03:00
Date: Tuesday 01.05.2018
StromPi-Output: mUSB
StromPi-Mode: mUSB
Raspberry Pi Shutdown: Disabled
Shutdown-Timer: 12901 seconds
Powerfail Warning: Disabled
Serial-Less Mode: Disabled
Power Save Mode: Disabled
Power-Off Mode: Disabled
Powerfailure-Counter: 13619
PowerOn-Button: Disabled
PowerOn-Button-Timer: 14384 seconds
FirmwareVersion: v1.8