Fix: Populate FK columns for SQLModel/SQLAlchemy relationships #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes validation errors when creating/editing records with required foreign key relationships by using SQLAlchemy introspection to automatically populate FK columns. Problem: - _arrange_data loaded relationship objects but didn't populate FK columns - Pydantic validation failed with 'Field required' error - Only affected MANYTOONE (HasOne) relationships with required FKs Solution: - Use SQLAlchemy's inspect() and synchronize_pairs to discover FK columns - Works with ANY FK naming (user_id, owner_id, created_by, etc.) - Works with ANY PK naming (id, uuid, etc.) - Handles composite keys, None relationships, self-referential FKs - Does NOT affect ONETOMANY or MANYTOMANY relationships Changes: - Modified: starlette_admin/contrib/sqla/view.py (_arrange_data method) - Added: tests/sqla/test_sqlmodel_custom_fk.py (custom FK naming tests) - Added: tests/sqla/test_sqlmodel_manytomany.py (association table tests) - All 94 tests pass (87 existing + 7 new) Fixes: jowilf#485, jowilf#687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes validation errors when creating/editing records with required foreign key relationships by using SQLAlchemy introspection to automatically populate FK columns.
Problem:
Solution:
Changes:
Fixes: #485, #687