fix-147 - Fix getting file for storage name with complex path #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
LucianDeveloper
changed the title
jowilf
requested changes
May 4, 2024
|
@LucianDeveloper Hey, any updates regarding this? Can we get this thing merged? |
|
@jowilf Can we somehow get this merged? If not how can I help to merge this in? Should I create a new pull request with this feature and test case? |
|
@NickNaskida, we need a simple test case. I haven't had the time to work on it myself yet. The quickest way to merge it is to create another PR with a test case, as you can't commit to this branch directly. |
|
Just did that, please take a look once you have time. Thanks! |
|
this is now implemented in #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.