add analytics tags to search #365
Conversation
|
What is possible with these tags? Can you please add a screenshot of how it looks in Algolia and a brief description what we can do with it? Overall this looks good. I have just two points that would be good to add:
|
|
This doesn’t add any tracking actually, it just filters the search queries done (anonymously & aggregated). However, turning analytics off altogether can make sense, and is something possible. I’m on mobile now, so I can’t make any screenshots, but I will Monday. |
|
Here's screenshots of what the analytics looks like. Note that this isn't filtered on Guppy only (also Yarn, Gatsby, codesandbox etc.) because I'd need this PR to be released before being able to pinpoint this to only Guppy usage. |
|
I'll advocate for this PR, as I believe it's important to be good stewards of Algolia's service since they're providing it free of charge. Some services (Reddit's API comes to mind) actually require that you identify yourself in order to make any requests, so I don't think it would be problematic in any way to add this to Guppy's Algolia integration. If we want to add an opt-out for analytics, that's really outside the scope of this and deserves its own PR. Since it's only logging the application's ID and nothing specific to each user, I don't think it even really justifies a mention in |
* Online check component added
* add reducer & action for online check component.
also included in App.js
* removed sidebar functionality when offline
* removed depedency functionality when offline
* removed functionality from create new project wizard when offline
* fixed tests to align with disabled pattern
* add infoBanner to Z-indexes for future usage.
* removed random {' '}, changed IS_ONLINE_CHECK to SET_ONLINE_STATUS
* pull request requested changes
missed one file.
* updated infobar to be fixed header.
* flow fix
* remove random whitespace
* Pull request changes
remove state type, move styled components to before redux part, change background color of infobar to be transparent.
* enable menu items based on isOnline
* WIP: Added eslint-jest & fixed issues (except snapshots) * reduced snapshot size to meet max 100 lines * fixed snapshot * changed comment to a note about noPadding prop * updated snapshot
* WIP: Added render test * WIP: Added tests * fixed flow * added focus test * Merge branch 'master' into test-project-configuration-modal * fixed linting warnings * removed typing as no flow used in test files
* WIP: Added tests * WIP: ProjectType undefined not throwing in test * fixed flow * added tests * reverted to children render props * Merge branch 'master' into test-create-new-project-wiz * Fixed linting & replaced snapshot with simple smoke tests * addressed review comments
* moved related components to DependencyManagementPane * added tests * fixed flow * added a constant instead of Date.now() * updated snapshot * removed white-spaces * removed verbose * fixed linting & mocked AlgoliaLogo * move related component files & moved tests to __tests__ folder * Add script for test:dev
* Switch to advanced config to silence validation warning * Fix spacing issues
|
Rebased! |
|
Damn it, how did this cause conflicts! |
Summary:
We add these tags so we can filter the analytics on searches done by Guppy alone. If you have interest in seeing those analytics, please make an Algolia account and let me know!