-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
🧐 What & Why
stop_recording
uses
pkill -SIGINT -f "simctl.*recordVideo"
This can terminate other users’ or unrelated simctl recordVideo
sessions, causing data loss and confusion.
🛠️ Proposal
- When spawning
xcrun … recordVideo
, capture the returnedChildProcess
object and storechild.pid
in aMap
keyed by UDID (or a singleton if only one recording allowed). - Replace
pkill
withprocess.kill(savedPid, 'SIGINT')
. - If no PID is stored, return an error:
No recording is currently running.
✅ Acceptance Criteria
-
record_video
saves its own PID. -
stop_recording
signals only that PID. - Unit tests verify PID storage and targeted kill.
- Legacy
pkill
code removed.
⚠️ Notes
If multiple recordings per UDID are later supported, extend the map to hold arrays of PIDs.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request