🐳 Docker Updates #101
Merged
🐳 Docker Updates #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for treehouse-bot ready! 🔨 Explore the source changes: 0cedcab 🔍 Inspect the deploy log: https://app.netlify.com/sites/treehouse-bot/deploys/6202c5e1cbde100007852281 😎 Browse the preview: https://deploy-preview-101--treehouse-bot.netlify.app |
turns out it's needed
|
When I use a distroless Node base image, it won't have npm, so #5 will be fixed. |
Image size now down to `46.97MB` for bot, `46.17MB` for server!
Might save up to 1:30m!
This is sodocker scanners can find it
merge stuff
We're not vulnerable anymore!
…bot into update-dockerignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
.dockerignore.Use experimental (and possibly unsafe)
scratch-nodebase image to reduce my docker images. This makes it so my images CVE-2021-3807.UPDATE: I'm forking the
scratch-noderepo so I can adddumb-initto it.UPDATE 2: I ended up building on top of
scratch-nodeto make a new base imagescratch-node-dumb-init, since I was waiting upwards of 4 hours for the CI script to build the image (I never even got it to work!).