Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knocking #71

Merged
merged 3 commits into from
Jul 26, 2020
Merged

Fix knocking #71

merged 3 commits into from
Jul 26, 2020

Conversation

rchh
Copy link
Contributor

@rchh rchh commented Jul 21, 2020

Fixed an issue where multiple calls to CSGO.CSGOClient(...).launch() without a GC response could create duplicate setInterval(this._sendClientHello, 2500) which will never stop sending k_EMsgGCClientHello.

@joshuaferrara
Copy link
Owner

I was hoping to get the CI build to pass by adding a small fix to the example, but I guess since it's still in the context of a PR the env vars don't get exposed so they'll fail. I ran the tests locally and they passed, so I'll pull this in shortly.

@joshuaferrara joshuaferrara merged commit 3ace49e into joshuaferrara:master Jul 26, 2020
@joshuaferrara
Copy link
Owner

Pulled it in - thank you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants