-
Notifications
You must be signed in to change notification settings - Fork 0
Add Lingo-Bot In Zoom Meeting #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances meeting URL extraction from Google Calendar events to support scheme-less URLs (e.g., "zoom.us/j/12345") and HTML-escaped text. The key improvements enable the bot to join more meetings by detecting meeting links in various formats.
- Adds support for extracting scheme-less meeting URLs (e.g., "zoom.us/j/12345") by prepending "https://"
- Implements HTML unescaping for calendar event fields to handle HTML-encoded content
- Restructures meeting URL extraction logic with better fallback handling and source tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| attendee/bots/tasks/sync_calendar_task.py | Enhanced extract_meeting_url_from_text to handle scheme-less URLs and HTML-escaped content; refactored _remote_event_to_calendar_event_data for better URL extraction with source tracking |
| Bot/app/api/meetings.py | Duplicates meeting URL extraction logic from sync_calendar_task with HTML unescaping and scheme-less URL support |
| Bot/Dockerfile | Reduces uvicorn workers from 4 to 1 |
Comments suppressed due to low confidence (2)
attendee/bots/tasks/sync_calendar_task.py:1
- The test
test_scheme_less_urlexpects scheme-less URLs to returnNone, but the new implementation now handles scheme-less patterns and returns a valid URL. This test will fail and needs to be updated to expect a valid URL likehttps://zoom.us/j/123456789instead ofNone.
import copy
attendee/bots/tasks/sync_calendar_task.py:1
- The test
test_mixed_case_scheme_and_hostexpects mixed-case URLs to returnNone, but with the newre.IGNORECASEflag onURL_CANDIDATE, this should now successfully match and return a URL. This test needs to be updated to reflect the new behavior.
import copy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.