Skip to content

Add yaml config #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 16, 2023
Merged

Add yaml config #13

merged 15 commits into from
Aug 16, 2023

Conversation

joshmedeski
Copy link
Owner

Closes #5

@joshmedeski
Copy link
Owner Author

@kenos1, can you look this over and give me feedback?

Also, what is the shell.nix and do you think it's a good idea to keep this in the repo?

@kenos1
Copy link
Contributor

kenos1 commented Jul 4, 2023

Oh the shell.nix was to enter a temporary environment with yq, bash-language-server and tmux. It is no longer needed. I was using it mainly to test yq without installing it and to use a LSP for bash for my text editor.

@kenos1
Copy link
Contributor

kenos1 commented Jul 4, 2023

Yeah, it looks good! Adding regex may also be useful but we will need to find a way to make that work. For now, I think just pushing this feature out in its form of basic yaml configuration when it's working fine should be enough.

Another suggestion I just thought of now is setting a custom window name format. Having an option to just show the icon and name in one format may be limiting to some people. This is probably easy to implement using sed though.

@joshmedeski
Copy link
Owner Author

I plan on merging and releasing this next week

@kenos1
Copy link
Contributor

kenos1 commented Jul 15, 2023

We should also notify users about breaking changes. Though it is just 2 options, users might be confused on why it broke.

@joshmedeski
Copy link
Owner Author

I'm thinking we can deprecate the options rather than break them. I can add notes to the release notes and README.

@kenos1
Copy link
Contributor

kenos1 commented Aug 10, 2023

Hey, it's been a month and this hasn't been merged yet. Should we merge now?

@oschrenk
Copy link
Contributor

Was about to issue a PR that adds Java with nf-fae-java as an icon to the old style. Will wait until this is merged.

@joshmedeski joshmedeski merged commit f0bfaff into main Aug 16, 2023
@joshmedeski joshmedeski deleted the yaml-config branch August 16, 2023 14:33
jlangston pushed a commit to jlangston/tmux-nerd-font-window-name that referenced this pull request Sep 8, 2023
* Added other text editors and utilities

* Add extra options

* Added package managers

* Fix tabs in code

* Add fzf and skim

* Init of custom icons branch

* Added recommended icons

* Add Nix

* Update README

* Add screenshot

* Init for yaml branch

* feat: set default configs

* feat: get user config to work

* docs: update docs

* chore: delete unused conf file

---------

Co-authored-by: Kenos <flatware-gold-bronze@tutanota.com>
jlangston pushed a commit to jlangston/tmux-nerd-font-window-name that referenced this pull request Sep 8, 2023
* Added other text editors and utilities

* Add extra options

* Added package managers

* Fix tabs in code

* Add fzf and skim

* Init of custom icons branch

* Added recommended icons

* Add Nix

* Update README

* Add screenshot

* Init for yaml branch

* feat: set default configs

* feat: get user config to work

* docs: update docs

* chore: delete unused conf file

---------

Co-authored-by: Kenos <flatware-gold-bronze@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Icon Mapping
3 participants