WIP: Add support for saving to Reader #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I don't know if the refactoring needs to happen now. The versions aren't in conflict with one another, and I (as a user) would rather not have to worry about the versioned interface (other than the version of the gem itself). |
|
@andjosh @andyw8 If we could start namespacing it would be helpful. My take is that at any point if we need to maintain two versions of a feature it would be troublesome. We may not need to refactor old ones but new ones can go into whatever versioning they are in and we can eventually refactor the rest. I can also pitch in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a start on #1
I'm wondering if the existing code should be refactored to separate out the v2 and v3 APIs?