Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent notification dropdown menu on mobile #143

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

josh-wong
Copy link
Owner

@josh-wong josh-wong commented Nov 10, 2024

Description

This PR fixes an issue where the notification dropdown menu (introduced in #121) is transparent when expanded on mobile devices.

Related issues and/or PRs

Changes made

  • Changed the position style for .notification-dropdown to make the dropdown menu cover the icons behind the dropdown menu on mobile.
  • Changed the width style for .navbar-sidebar .notification-wrapper to make the notification dropdown menu stay within the expanded menu on mobile.
  • Changed the position style for .header-rss-link::before to make the RSS icon match the same behavior of the other icons in the navbar on mobile.
  • Reduced the distance between the notification bell icon and the notification count.

Checklist

The following is a best-effort checklist. If any items in this checklist aren't applicable to this PR, add N/A after each item.

Documentation

  • I have updated the side navigation as necessary. N/A
  • I have updated the documentation to reflect the changes. N/A
  • I have documented or updated any remaining open issues linked to this PR in GitHub, Obsidian, etc.

Build, deploy, and test

  • I have merged and published any dependent changes in other PRs. N/A
  • I have commented my code, particularly in hard-to-understand areas. N/A
  • I have checked that my changes look as expected on a locally built version of the docs site.
  • My changes generate no new warnings.

Change `position` and `width` so that, when `notification-dropdown` is active, the dropdown window covers the icons behind the dropdown menu.
@josh-wong josh-wong added the bugfix Bug is fixed label Nov 10, 2024
@josh-wong josh-wong self-assigned this Nov 10, 2024
Copy link
Contributor

All items in the checklist have been checked🎉

Copy link
Contributor

All items in the checklist have been checked🎉

1 similar comment
Copy link
Contributor

All items in the checklist have been checked🎉

@josh-wong josh-wong merged commit 51d0327 into main Nov 10, 2024
2 checks passed
@josh-wong josh-wong deleted the fix-notification-dropdown-on-mobile branch November 10, 2024 03:42
@josh-wong josh-wong added docusaurus Feature related to Docusaurus and removed docusaurus Feature related to Docusaurus labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open notification dropdown menu is transparent, showing other menu icons on mobile
1 participant