Skip to content

Conversation

christian-schilling
Copy link
Member

No description provided.

@christian-schilling christian-schilling force-pushed the @changes/master/christian.schilling.de@gmail.com/fix-handlebars branch from 0ecfcb2 to a276e61 Compare May 29, 2023 11:07
Copy link
Collaborator

@LMG LMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what about making it a helper since all of the code is super similar? Also you need to run cargo fmt again (or maybe your version is wrong)

@christian-schilling christian-schilling force-pushed the @changes/master/christian.schilling.de@gmail.com/fix-handlebars branch from a276e61 to b977b91 Compare May 29, 2023 16:58
The handlebars code was not yet converted to using alternate object stores.
We did not notice this issue at first,  because templateing is only tested with the
cli and the cli does not use alternates.

Change: fix-handlebars
@christian-schilling christian-schilling force-pushed the @changes/master/christian.schilling.de@gmail.com/fix-handlebars branch from b977b91 to c40f808 Compare May 30, 2023 14:44
@LMG LMG merged commit 8a764ad into master May 30, 2023
@LMG LMG deleted the @changes/master/christian.schilling.de@gmail.com/fix-handlebars branch May 30, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants