Don't count characters above the SMP as surrogates #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supplementary plane lies between 0xd800 and 0xdfff, anything outside that range should not be counted as a pair.
|
Indeed! I think it may be useful to merge this PR :) |
|
Oh sorry for leaving you in the lurch - I must have missed the notification for this! |
|
Nice catch - thanks for the fix! It’d be good to add a test case too if you want to suggest one to make sure we don’t get regressions. |
josephg
added a commit
to ottypes/text-unicode
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supplementary plane lies between 0xd800 and 0xdfff, anything outside that range should not be counted as a pair.