clear button to type="button"

joselazovargas · May 14, 2023 · afc8915 · afc8915
1 parent 976bf3e
commit afc8915
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/lib/Select.svelte b/src/lib/Select.svelte
@@ -795,7 +795,7 @@
         {/if}
 
         {#if showClear}
-            <button class="icon clear-select" on:pointerup|preventDefault|stopPropagation={handleClear}>
+            <button type="button" class="icon clear-select" on:click={handleClear}>
                 <slot name="clear-icon">
                     <ClearIcon />
                 </slot>

diff --git a/test/src/tests.js b/test/src/tests.js
@@ -1458,8 +1458,7 @@ test('when multiple is true and items are selected then clear all should wipe al
     }
   });
 
-  const event = new PointerEvent('pointerup')
-  document.querySelector('.clear-select').dispatchEvent(event);
+  document.querySelector('.clear-select').click();
   t.equal(select.value, undefined);
 
   select.$destroy();
@@ -1790,8 +1789,7 @@ test('when value is cleared the clear event is fired', async (t) => {
     clearEvent = true;
   });
 
-  const event = new PointerEvent('pointerup')
-  document.querySelector('.clear-select').dispatchEvent(event);
+  document.querySelector('.clear-select').click();
 
   t.ok(clearEvent);
 
@@ -1840,8 +1838,7 @@ test('when single item is cleared the clear event is fired with removed item', a
     removedItem = event.detail;
   });
 
-  const event = new PointerEvent('pointerup')
-  document.querySelector('.clear-select').dispatchEvent(event);
+  document.querySelector('.clear-select').click();
   t.equal(JSON.stringify(removedItem), JSON.stringify(itemToRemove));
 
   select.$destroy();