Backing up releases using fine grained token ends with an error#257
Merged
Conversation
When downloading assets using a fine grained token you will get a "can't
concat str to bytes" error. This is due to the fine grained token being
concatenated onto bytes in the line:
`request.add_header("Authorization", "Basic ".encode("ascii") + auth)`
This is better handled in the function `_construct_request` so I changed
the lines that construct the request in `download_file` to use the
function `_construct_request` and updated the function signature to
reflect that.
Owner
|
Seems like this fails linting. |
That are triggering flake.
Contributor
Author
|
Sorry, removed trailing whitespaces |
josegonzalez
changed the title
ethanwhite
added a commit
to ethanwhite/python-github-backup
that referenced
this pull request
Dec 28, 2024
The issue with --release producing errors documented in josegonzalez#209 (the linked issue) and josegonzalez#234 appears to have been fixed in josegonzalez#257. This change removes the associated warning from the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #234
Summary
download_fileto be built by_construct_requestas it handles authentication with fine grained tokens betterdownload_fileparams to include optionalas_appand optionalfineso these arguments can be passed into_construct_requestProblem
When downloading assets using a fine grained token you will get a "can't concat str to bytes" error. This is due to the fine grained token being concatenated onto bytes in the line:
request.add_header("Authorization", "Basic ".encode("ascii") + auth)This is fixed by using the
_construct_requestfunction.