-
Notifications
You must be signed in to change notification settings - Fork 18
Added support for custom and composite foreign keys. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for custom and composite foreign keys. #14
Conversation
|
Can you add a test for this case? |
This tests also cover a fix for VersionTrait and a fix for checking that version_id column is present in table schema.
bf989a0 to
5267509
Compare
|
@josegonzalez I've included tests for composite keys handling which also cover that trait fix from #15. Also found a bug I introduced some time ago, where version_id would never be set in an entity if this field wasn't versioned. It's fixed and assertion has been added for it. |
|
Ahh sorry, found some bugs. |
|
Most of the new code isn't covered, so if you want this merged, you're going to need to give me coverage on that. |
|
Fuck it, if someone wants this feature and its broken, they can write the docs and fix tests. |
Making the plugin more flexible: part one :)