Skip to content

Conversation

@robertpustulka
Copy link
Contributor

Making the plugin more flexible: part one :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 95.041% when pulling 8fab7a2 on robertpustulka:composite-keys into 6935921 on josegonzalez:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 90.551% when pulling bf989a0 on robertpustulka:composite-keys into 6935921 on josegonzalez:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 90.551% when pulling bf989a0 on robertpustulka:composite-keys into 6935921 on josegonzalez:master.

@josegonzalez
Copy link
Owner

Can you add a test for this case?

@robertpustulka
Copy link
Contributor Author

@josegonzalez
I've megred PR #15 as testing this new feature makes no sense without that fix :)

I've included tests for composite keys handling which also cover that trait fix from #15.

Also found a bug I introduced some time ago, where version_id would never be set in an entity if this field wasn't versioned. It's fixed and assertion has been added for it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.09%) to 90.909% when pulling 5267509 on robertpustulka:composite-keys into 6935921 on josegonzalez:master.

@robertpustulka
Copy link
Contributor Author

robertpustulka commented Jun 17, 2016

Is there anything more to do or could it be merged?

Ahh sorry, found some bugs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.09%) to 90.909% when pulling 17eafd6 on robertpustulka:composite-keys into 6935921 on josegonzalez:master.

@josegonzalez
Copy link
Owner

Most of the new code isn't covered, so if you want this merged, you're going to need to give me coverage on that.

@josegonzalez
Copy link
Owner

Fuck it, if someone wants this feature and its broken, they can write the docs and fix tests.

@josegonzalez josegonzalez merged commit 47f796e into josegonzalez:master Sep 19, 2016
@robertpustulka robertpustulka deleted the composite-keys branch November 3, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants