Prevent duplicate ids #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 6, 2015 14:51
Because of this error the pageX variable is leaked onto the window object.
Hex is already declared as a function argument and thus does not need var.
Missing var declarations.
When having a bigger amount of color pickers on a page it would happen that multiple pickers had the same id. By using a counter that increments for each color picker the id is now guaranteed to be unique.
mrgrain
added a commit
to mrgrain/colpick
that referenced
this pull request
May 27, 2015
|
👍 |
|
perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a bigger amount of color pickers on a page it would happen that
multiple pickers had the same id.
By using a counter that increments for each color picker the id is now
guaranteed to be unique.
Also includes some missing var declarations.