Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Elixir 1.17 #31

Merged
merged 1 commit into from
Aug 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions .github/workflows/example_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
test:
name: Tests & Checks
name: Tests & Checks (Elixir ${{ matrix.elixir }} / OTP ${{ matrix.otp }})
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -19,23 +19,34 @@ jobs:
env:
MIX_ENV: test

strategy:
matrix:
include:
- elixir: '1.15.x'
otp: '25.x'
- elixir: '1.16.x'
otp: '26.x'
- elixir: '1.17.x'
otp: '27.x'

steps:
- uses: actions/checkout@v4

- name: Setup Erlang and Elixir
uses: erlef/setup-beam@v1.17
uses: erlef/setup-beam@v1.18
with:
elixir-version: "1.16.0-otp-26"
otp-version: "26.0"
elixir-version: ${{ matrix.elixir }}
otp-version: ${{ matrix.otp }}

- name: Mix and build cache
uses: actions/cache@v4
with:
path: |
./tests/example_app/deps
./tests/example_app/_build
key: ${{ runner.os }}-mix-${{ hashFiles('**/mix.lock') }}
restore-keys: ${{ runner.os }}-mix-
key: ${{ runner.os }}-mix-${{ matrix.elixir }}-${{ matrix.otp }}-${{ hashFiles('**/mix.lock') }}
restore-keys: |
${{ runner.os }}-mix-${{ matrix.elixir }}-${{ matrix.otp }}-

- name: Get dependencies
run: mix deps.get
Expand Down
21 changes: 20 additions & 1 deletion lib/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ const calculatedData = (data, coverageThreshold) => ({
testsSuccess: data.totalFailures === 0,
});

const parser = {
// Used for Elixir <= 1.16
const oldParser = {
pattern: /(.+?)(?=Finished)(.+sync\))\n(.*?)([0-9]+ failure[s]?)(.+)(Randomized with seed [0-9]+)(.+)(Percentage \| Module.+)( [0-9]+\.[0-9]+%)( \| Total)/gs,
mapGroupsToData: (groups) => ({
summary: groups[2],
Expand All @@ -15,7 +16,25 @@ const parser = {
}),
};

// Used for Elixir >= 1.17
const newParser = {
pattern: /(Running ExUnit with seed: [0-9]+, max_cases: [0-9]+\n\n)(.+?)(?=Finished)(Finished.+sync\))\n(.*?)([0-9]+ failure[s]?)(.+?)(Percentage \| Module.+)((?:\n.+)+\n-+\|-+\n\s+([0-9]+\.[0-9]+)%\s+\|\s+Total)/s,
mapGroupsToData: (groups) => ({
summary: groups[3],
tests: groups[4].slice(0, -2),
totalFailures: parseInt(groups[5]),
totalCoverage: parseFloat(groups[9]),
randomizedSeed: groups[1].trim(),
coverageTable: groups[7] + groups[8],
}),
};

const detectFormat = (output) => output.includes("Running ExUnit with seed:") ? "new" : "old";

const parseData = (output, coverageThreshold) => {
const format = detectFormat(output);
const parser = format === "new" ? newParser : oldParser;

try {
parser.pattern.lastIndex = 0;
const groups = parser.pattern.exec(output);
Expand Down
25 changes: 25 additions & 0 deletions tests/fixtures/success_03
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Running ExUnit with seed: 922031, max_cases: 8

.......................................
Finished in 0.1 seconds (0.07s async, 0.03s sync)
1 doctest, 38 tests, 0 failures

Generating cover results ...

Percentage | Module
-----------|--------------------------
100.00% | Example.Application
100.00% | Example.Lists
100.00% | Example.Math
100.00% | Example.Strings
100.00% | ExampleWeb
100.00% | ExampleWeb.ConnCase
100.00% | ExampleWeb.Endpoint
100.00% | ExampleWeb.ErrorJSON
100.00% | ExampleWeb.IndexController
100.00% | ExampleWeb.Router
-----------|--------------------------
100.00% | Total

Generated HTML coverage results in "cover" directory
success running the tests
11 changes: 7 additions & 4 deletions tests/lib/parser.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,14 @@ describe('parser tests', () => {
const fixture = fs.readFileSync(file, 'utf8');
const output = parser(fixture, 80);

const summaryFormat = /^Finished in [0-9.]+ seconds \([0-9.]+s async, [0-9.]+s sync\)$/;
expect(output.summary).toMatch(summaryFormat);
// Format for Elixir versions before 1.17
const oldSeedFormat = /^Randomized with seed [0-9]+$/;

// Format for Elixir versions 1.17 and later
const newSeedFormat = /^Running ExUnit with seed: [0-9]+(?:, max_cases: [0-9]+)?$/;

expect(oldSeedFormat.test(output.randomizedSeed) || newSeedFormat.test(output.randomizedSeed)).toBe(true);

const seedFormat = /^Randomized with seed [0-9]+$/;
expect(output.randomizedSeed).toMatch(seedFormat);
expect(Number.isInteger(output.totalFailures)).toBe(true);
expect(typeof output.totalCoverage).toBe('number');
});
Expand Down
Loading