fix: ensure fallback image is available in the view model -> Issue #760 #763
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What - Add defaultImage to the ModelAndView in save endpoint. - Wire defaultImage so carousel fallback works in the listForAdoption.html template Why - Enables the Thymeleaf fallback when pet.images is empty, preventing empty/broken thumbnails. Impact - View-only change; no storage or controller logic altered. - Backwards compatible. Requires that gcpImageUrl + defaultImage resolve to a valid image.
josdem
approved these changes
Oct 28, 2025
josdem
requested review from
62arondsouza,
CecyRamirez,
bestemic,
Copilot,
egvr2002,
ernestorbemx,
jose-espericueta,
kaminuma,
kiranraoboinapally and
tj330
|
@all-contributors please add @technologic-technologic for code |
|
I've put up a pull request to add @technologic-technologic! 🎉 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for displaying a default image when pets have no uploaded images in the adoption listing page. The changes ensure that pets without images still have a visual representation in the UI.
- Added fallback display logic to show a default image when
pet.imagesis empty - Injected
defaultImageconfiguration value intoAdoptionController - Passed
defaultImageto the template model for rendering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/resources/templates/pet/listForAdoption.html | Added conditional block to display default image when pet has no images |
| src/main/java/com/josdem/vetlog/controller/AdoptionController.java | Added defaultImage field injection and passed it to the model for the template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #760
Issue: Adoption save container does not contain default image
What
Why
Impact
Behavior
Before: Pets with images display correctly; pets without images render no thumbnail.
After: Pets with images still display correctly (no changes); pets without images render the configured default image. Added component that reads the defaultImage. Just like other templates that does render the default Image.