Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invmodgives a wrong-range result when the modulus is negative:mod()already returns a value with the sign ofb, so afterinv = mod(inv, b)the result lies between0andb. The extraif (inv < 0) inv = add(inv, b)step can only fire for a negativeb, and then it moves the value out of that range. (-18is still congruent, but it's not the reduced inverse, and it doesn't match whatmodreturns.) For a positivebthe branch never runs, so removing it changes nothing there.The new results match Python's
pow(a, -1, m), e.g.pow(3, -1, -11) == -7.This PR removes that step and the
smaller/adddependencies that are no longer used, and adds tests for a negative modulus with numbers and BigNumbers.npx mocha test/unit-tests/function/arithmetic/passes and eslint is clean.