Don't try to create file with no output #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Thanks for contributing! Could you show a short Gulpfile that fails? And could you perhaps try to make a test that fails without your change and works with your change? |
|
Sorry, don't really have the bandwidth for that. Went with a different solution for this in the end, so this PR was just an easy way to effectively file an issue on this. In my use case the RequireJS config had no main file, only modules, and the output uses the |
|
OK. Me neither to be honest. |
|
I have released the change in a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using the optimizer to only build modules and/or with the
diroption,outputis never set and theBuffer.from(output)increateFile()fails. So let's not do that.