Skip to content

improve path readability by muting color of directory string #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorio merged 3 commits into from
Oct 28, 2025
Merged

improve path readability by muting color of directory string #77

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5501215
improve path readability by muting color of directory string
tomkoenecke Oct 24, 2025
6f77e4d
gray text also for selected entries
tomkoenecke Oct 27, 2025
f7c8ec8
remove whitespace from blank line
tomkoenecke Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion gitfourchette/filelists/filelist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,43 @@ def paint(self, painter: QPainter, option: QStyleOptionViewItem, index: QModelIn
painter.setFont(font)
fullText = index.data(Qt.ItemDataRole.DisplayRole)
text = painter.fontMetrics().elidedText(fullText, option.textElideMode, textRect.width())
painter.drawText(textRect, option.displayAlignment, text)

# Split path into directory and filename for better readability
dirPortion = None
filePortion = None

if '/' in fullText:
slashesInFull = fullText.count('/')
slashesInElided = text.count('/')

if slashesInFull > slashesInElided:
# A slash was elided - gray everything up to the ellipsis
ellipsisPos = text.find('\u2026')
dirPortion = text[:ellipsisPos + 1]
filePortion = text[ellipsisPos + 1:]
elif slashesInElided > 0:
# No slash elided - gray up to the last slash
lastSlash = text.rfind('/')
dirPortion = text[:lastSlash + 1]
filePortion = text[lastSlash + 1:]

if dirPortion is not None:
textColor = QPalette.ColorRole.WindowText if not isSelected else QPalette.ColorRole.HighlightedText

# Draw directory with muted color
mutedColor = option.palette.color(colorGroup, textColor)
mutedColor.setAlphaF(0.4)
painter.setPen(mutedColor)
painter.drawText(textRect, Qt.AlignmentFlag.AlignLeft | Qt.AlignmentFlag.AlignVCenter, dirPortion)

# Draw filename with normal color
painter.setPen(option.palette.color(colorGroup, textColor))
dirWidth = painter.fontMetrics().horizontalAdvance(dirPortion)
fileRect = QRect(textRect)
fileRect.setLeft(textRect.left() + dirWidth)
painter.drawText(fileRect, Qt.AlignmentFlag.AlignLeft | Qt.AlignmentFlag.AlignVCenter, filePortion)
else:
painter.drawText(textRect, option.displayAlignment, text)

# Highlight search term
if searchTerm and searchTerm in fullText.lower():
Expand Down