Skip to content

ufl.Function().geometric_dimension() is deprecated #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cganuza
Copy link

@cganuza cganuza commented Dec 14, 2022

In the latest version of dolfinx (currently v0.5.2 released on Oct 27) includes the latest version of UFL(v2022.2.0) no longer suport the method geometric_dimension of ufl.Function.

The exact function can be imported with: from ufl.domain import find_geometric_dimension but in the dolfinx demos for python (for example in the elasticity demo script line 112) the prerrefered way is using the python built in function len().

In the latest version of dolfinx (currently v0.5.2 released on Oct 27) includes the latest version of UFL(v2022.2.0) no longer suport the method geometric_dimension of the ufl.Function. The exact function can be imported with: `from ufl.domain import find_geometric_dimension` but in the dolfinx demos for python the prerrefered way is using len().
@jorgensd
Copy link
Owner

This change was introduced after 2022.2.0, namely in: FEniCS/ufl#131
which means that this change will be merged at the next dolfinx release (0.6.0).

@jorgensd
Copy link
Owner

@cganuza Please also change the corresponding Python file. This can be done automatically with jupytext.

@cganuza
Copy link
Author

cganuza commented Jan 25, 2023

Sorry for the delay. I've also change it at the corresponding python file.

@jorgensd jorgensd changed the base branch from dokken/jupyterbook to dokken/release January 25, 2023 16:01
@jorgensd
Copy link
Owner

Could you try again? I have to send this into the release branch.

@jorgensd
Copy link
Owner

jorgensd commented Feb 1, 2023

Done in #95

@jorgensd jorgensd closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants