Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message when a feature is not active #69

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Nov 23, 2021

This allows to match for an error type related to the lack of a feature installed (e.g. to propagate the message to the end user).

Backward incompatible change:

  • ParquetError got a new variant and became #[non_exhaustive], thereby forbidding a complete match (to make it future proof against changes to it)

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #69 (ca35b2a) into main (96596e6) will increase coverage by 0.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   69.18%   69.56%   +0.37%     
==========================================
  Files          66       66              
  Lines        3661     3703      +42     
==========================================
+ Hits         2533     2576      +43     
+ Misses       1128     1127       -1     
Impacted Files Coverage Δ
src/compression.rs 89.70% <ø> (ø)
src/error.rs 22.22% <0.00%> (-6.35%) ⬇️
src/read/mod.rs 94.59% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96596e6...ca35b2a. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit e0f9899 into main Nov 24, 2021
@jorgecarleitao jorgecarleitao deleted the feature branch November 24, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants