Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix parquet datatype conversion from arrow #1570

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix parquet datatype conversion from arrow #1570

merged 2 commits into from
Sep 22, 2023

Conversation

sundy-li
Copy link
Collaborator

@sundy-li sundy-li commented Sep 22, 2023

changes:

  1. fix parquet datatype conversion from arrow
  2. make clippy happy

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 72.72% and no project coverage change.

Comparison is base (fb7b5fe) 83.06% compared to head (3645487) 83.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files         391      391           
  Lines       42889    42898    +9     
=======================================
+ Hits        35626    35634    +8     
- Misses       7263     7264    +1     
Files Changed Coverage Δ
src/io/odbc/read/deserialize.rs 0.00% <0.00%> (ø)
src/temporal_conversions.rs 88.85% <33.33%> (ø)
src/io/parquet/read/schema/convert.rs 94.73% <70.00%> (+0.04%) ⬆️
src/compute/cast/mod.rs 90.84% <100.00%> (+0.01%) ⬆️
src/io/csv/read_utils.rs 91.39% <100.00%> (ø)
src/io/parquet/write/schema.rs 77.20% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundy-li
Copy link
Collaborator Author

cc review @b41sh @TCeason

@TCeason
Copy link
Contributor

TCeason commented Sep 22, 2023

LGTM.

@sundy-li sundy-li merged commit 231a6fa into main Sep 22, 2023
47 of 49 checks passed
@sundy-li sundy-li deleted the sundy-li-patch-1 branch September 22, 2023 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants