feat: add fallible extend to mutable arrays (#1546)

jorgecarleitao · Aug 20, 2023 · 2b3e2a9 · 2b3e2a9
1 parent 7edf5f9
commit 2b3e2a9
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 0 deletions.
diff --git a/src/array/binary/mutable.rs b/src/array/binary/mutable.rs
@@ -404,6 +404,18 @@ impl<O: Offset> MutableBinaryArray<O> {
         let (offsets, values) = values_iter(iterator);
         Self::try_new(Self::default_data_type(), offsets, values, None).unwrap()
     }
+
+    /// Extend with a fallible iterator
+    pub fn extend_fallible<T, I, E>(&mut self, iter: I) -> std::result::Result<(), E>
+    where
+        E: std::error::Error,
+        I: IntoIterator<Item = std::result::Result<Option<T>, E>>,
+        T: AsRef<[u8]>,
+    {
+        let mut iter = iter.into_iter();
+        self.reserve(iter.size_hint().0, 0);
+        iter.try_for_each(|x| Ok(self.push(x?)))
+    }
 }
 
 impl<O: Offset, T: AsRef<[u8]>> Extend<Option<T>> for MutableBinaryArray<O> {

diff --git a/src/array/binary/mutable_values.rs b/src/array/binary/mutable_values.rs
@@ -314,6 +314,18 @@ impl<O: Offset> MutableBinaryValuesArray<O> {
         }
         Ok(array)
     }
+
+    /// Extend with a fallible iterator
+    pub fn extend_fallible<T, I, E>(&mut self, iter: I) -> std::result::Result<(), E>
+    where
+        E: std::error::Error,
+        I: IntoIterator<Item = std::result::Result<T, E>>,
+        T: AsRef<[u8]>,
+    {
+        let mut iter = iter.into_iter();
+        self.reserve(iter.size_hint().0, 0);
+        iter.try_for_each(|x| Ok(self.push(x?)))
+    }
 }
 
 impl<O: Offset, T: AsRef<[u8]>> Extend<T> for MutableBinaryValuesArray<O> {

diff --git a/src/array/utf8/mutable.rs b/src/array/utf8/mutable.rs
@@ -483,6 +483,18 @@ impl<O: Offset> MutableUtf8Array<O> {
     pub fn from_iter_values<T: AsRef<str>, I: Iterator<Item = T>>(iterator: I) -> Self {
         MutableUtf8ValuesArray::from_iter(iterator).into()
     }
+
+    /// Extend with a fallible iterator
+    pub fn extend_fallible<T, I, E>(&mut self, iter: I) -> std::result::Result<(), E>
+    where
+        E: std::error::Error,
+        I: IntoIterator<Item = std::result::Result<Option<T>, E>>,
+        T: AsRef<str>,
+    {
+        let mut iter = iter.into_iter();
+        self.reserve(iter.size_hint().0, 0);
+        iter.try_for_each(|x| Ok(self.push(x?)))
+    }
 }
 
 impl<O: Offset, T: AsRef<str>> Extend<Option<T>> for MutableUtf8Array<O> {

diff --git a/src/array/utf8/mutable_values.rs b/src/array/utf8/mutable_values.rs
@@ -359,6 +359,18 @@ impl<O: Offset> MutableUtf8ValuesArray<O> {
         }
         Ok(array)
     }
+
+    /// Extend with a fallible iterator
+    pub fn extend_fallible<T, I, E>(&mut self, iter: I) -> std::result::Result<(), E>
+    where
+        E: std::error::Error,
+        I: IntoIterator<Item = std::result::Result<T, E>>,
+        T: AsRef<str>,
+    {
+        let mut iter = iter.into_iter();
+        self.reserve(iter.size_hint().0, 0);
+        iter.try_for_each(|x| Ok(self.push(x?)))
+    }
 }
 
 impl<O: Offset, T: AsRef<str>> Extend<T> for MutableUtf8ValuesArray<O> {