Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support no cache buster for css filename but with icon files #113

Closed
wants to merge 1 commit into from
Closed

Conversation

adyliu
Copy link
Contributor

@adyliu adyliu commented Nov 15, 2013

usage: --cachebuster-filename --nocachebuster_cssfilename

usage: --cachebuster-filename --nocachebuster_cssfilename
@jorgebastida
Copy link
Owner

Hello @adyliu - Could you please explain what's the use case of this feature?

@adyliu
Copy link
Contributor Author

adyliu commented Dec 11, 2013

We need the images with cachebuster filename to remove the cache in the CDN service, but the css files will been renamed and deployed to the CDN with other tools.

So the original file name must been kept for the css files except the images.

@oleg-codaio
Copy link

This would actually be pretty useful.

For instance, I use glue with Sass and for the @include statement to correctly insert the contents of the file into my main CSS file, I need the sprite css file to be constant.

Right now my workaround is to have a step that removes these endings from the CSS file.

@ianva
Copy link

ianva commented Feb 21, 2014

Nice feature! +1

1 similar comment
@tokki
Copy link

tokki commented Feb 21, 2014

Nice feature! +1

@qddxct
Copy link

qddxct commented Feb 21, 2014

perfect feature!

@sarowlwp
Copy link

Useful feature ~

1 similar comment
@tingwind
Copy link

Useful feature ~

@jorgebastida
Copy link
Owner

I'm going to review this during the weekend and probably merge it.
btw @sarowlwp @qddxct are you using glue at Sohu.com?

jorgebastida added a commit that referenced this pull request Feb 23, 2014
@jorgebastida
Copy link
Owner

I've just pushed into master a new option named --cachebuster-filename-only-sprites. This option will make glue only cachebust sprite images and not CSS files. I'm going to release this changes as glue 0.9.2.

@adyliu Thank you very much for your Pull Request. Unfortunately I can't use it as we rewrote glue from scratch from 0.4 to 0.9. I've add you to the AUTHORS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants