Fixed the dajaxice.core.js generation issue for Windows users #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forward slash works for POSIX and Linux systems. If you're using Windows, an escaped backslash would be needed. By using os.sep, we don't have to worry about this.
Owner
|
Hello @geboyr ! Thank you very much for your Pull Request :D |
jorgebastida
added a commit
that referenced
this pull request
Sep 4, 2012
Fixed the dajaxice.core.js generation issue for Windows users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I believe I have fixed the dajaxice.core.js generation issue for Windows users that some people have talked about: https://groups.google.com/forum/#!topic/dajaxproject/9Ap9xDn526I
I changed the special character you were looking for '/' to be os.sep instead, so you don't have to worry about the operating system.
I found the issue in 5 minutes, but spent the better part of an hour learning how to use github so I could officially send my first pull request to you :)
I hope this helps your users.
Thanks!