feat: Log unhandledRejection & uncaughtException #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logging to unhandledRejection and uncaughtException events. We use the framework logger so that the exception ends up in the app log file as well as the console. Usually it would end up in stderr, meaning the user would need to dig into their Docker logs.
Typically unhandledRejection's would cause a process exit, but here I am allowing the program to continue. These are likely to be from our usage of throw away Promises that do not have a catch attached. We should either be awaiting these or attaching a catch.
uncaughtException events will cause the process to exit, as it would usually.
I've also updated the exit code when data directory validation fails, as
0
signals a success.Checklist
How to test
Please describe the steps to test your changes, including any setup required.
Create a scenario where an unhandled reject would occur. I used this in
rules.controller.ts executeRules
and then "Run rules":