Skip to content

fix: Is (part of) latest aired/airing season should exclude future #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benscobie
Copy link
Collaborator

@benscobie benscobie commented Apr 19, 2025

Description

We were not checking if the returned dates were in the future and the rule description makes it sound like these would not be counted. The statistics nextAiring and previousAiring are based on the episode data + monitoring status so there's no need to check these here.

Related issue

Fixes #1730

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my code.
  • I have linted and formatted my code.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.

How to test

Please describe the steps to test your changes, including any setup required.

  1. Create a rule that targets Sonarr - Is (part of) latest aired/airing season
  2. Find a show that has an upcoming season
  3. Run rules and verify the result

@benscobie benscobie requested review from ydkmlt84 and jorenn92 April 19, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonarr - Is (part of) latest aired/airing season does not exclude future season
1 participant