Change labels for sonarr actions with mediaType=shows for clarity #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisermann
force-pushed
the
clearer-sonarr-action-for-shows
branch
from
93bb36d to
2156b76
Compare
benscobie
reviewed
Mar 23, 2025
| }, | ||
| { | ||
| id: 2, | ||
| name: 'Unmonitor and delete existing seasons / episodes', | ||
| name: 'Unmonitor show and delete existing seasons / episodes', |
There was a problem hiding this comment.
It might be worth being more verbose about what will happen. It's not obvious what happens to the monitor status of seasons & episodes. From my interpretation:
Unmonitors show
Keeps seasons monitored
Unmonitors and deletes existing episodes
benscobie
reviewed
Mar 23, 2025
| @@ -580,11 +580,11 @@ const AddModal = (props: AddModal) => { | |||
| }, | |||
| { | |||
| id: 1, | |||
| name: 'Unmonitor and delete all seasons / episodes', | |||
| name: 'Unmonitor show and delete all seasons / episodes', | |||
There was a problem hiding this comment.
Same for this but I need to validate what happens to the episode monitor status. It doesn't look like we explicitly unmonitor each episode, but I am wondering if unmonitoring the season somehow causes the episodes to be unmonitored:
Unmonitors show
Unmonitors seasons
Unmonitors(?) and deletes existing episodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this discussion and my own confusion around these Sonarr actions when
mediaType=shows, I just added ashowafter theunmonitorverb so it's clearer what the code is actually doing.This also aligns the other options with the existing
Unmonitor show and keep filesone, which already has "show" after "unmonitor"