Skip to content

Conversation

jorenham
Copy link
Owner

@jorenham jorenham commented Oct 7, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 01:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the build configuration to suppress warnings from Boost headers while promoting project warnings to errors. The change treats Boost headers as system includes to avoid warning noise from third-party code.

  • Replaced .warnings(true) with .warnings_into_errors(true) to make project warnings into build failures
  • Added -isystem flag to treat Boost headers as system includes, suppressing their warnings
  • Extracted Boost include path to a variable for reuse

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham force-pushed the ignore-boost-cpp-warnings branch from 624e75a to edfa208 Compare October 7, 2025 01:47
@jorenham jorenham requested a review from Copilot October 7, 2025 01:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham force-pushed the ignore-boost-cpp-warnings branch from d9220d0 to 5ac41fc Compare October 7, 2025 02:00
@jorenham jorenham merged commit 0dbb327 into master Oct 7, 2025
13 of 14 checks passed
@jorenham jorenham deleted the ignore-boost-cpp-warnings branch October 7, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant