Skip to content

Conversation

jorenham
Copy link
Owner

@jorenham jorenham commented Oct 5, 2025

This adds the following functions to the boost::math namespace:

  • acosh
  • asinh
  • atanh

@Copilot Copilot AI review requested due to automatic review settings October 5, 2025 20:24
@jorenham jorenham added the enhancement New feature or request label Oct 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds inverse hyperbolic functions (acosh, asinh, atanh) to the boost::math namespace wrapper, providing Rust bindings for these mathematical functions that were previously unimplemented.

  • Adds FFI bindings and wrapper functions for acosh, asinh, and atanh
  • Includes comprehensive test coverage for all three functions
  • Updates documentation to mark these functions as implemented

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wrapper.cpp Adds C++ wrapper functions and includes for inverse hyperbolic functions
src/math/special_functions/mod.rs Declares new modules for the three inverse hyperbolic functions
src/math/special_functions/atanh.rs Implements atanh function with tests and documentation
src/math/special_functions/asinh.rs Implements asinh function with tests and documentation
src/math/special_functions/acosh.rs Implements acosh function with tests and documentation
src/math/mod.rs Updates documentation and exports the new functions
src/ffi.rs Adds FFI declarations for the C++ wrapper functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jorenham jorenham merged commit c68f7c6 into master Oct 5, 2025
9 checks passed
@jorenham jorenham deleted the inverse_hyperbolic branch October 5, 2025 20:30
@jorenham jorenham added this to the v0.0.3 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant