Emit timer logs at specified log level #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the timer logs, however I'd love to be able to have different ones emitted at different levels. e.g. setup some DEBUG timers that I wouldn't normally want to know about.
This pull request isn't really ready to merge, but I wanted to discuss what I was trying to achieve :)
I've added the current log level into the timer log.
I'm not sure of the best way to proceed. I was thinking of sometime like:
logger.time("some_message", "level") { do_stuff }
And default the "level" to be :info.
But I can't work out how to call into the logger mixin so that I could check if the level matches the level we are logging at.
What do you think?