Fixes for #8 - Ubuntu 11.10 Makefile #9
Conversation
Attempted fixes for issue #8. Created a script that will grab the ubuntu version number from the /etc/issue file. Make changes to the Makefile so that if Ubuntu 11.10 is detected then the gcc command string is changed to put the LDFLAGS var at the end of the line.
Previous commit was too hasty. The test suite hadn't been run and was failing, and the changes hadn't been added to libgrok. Adding the LDFLAGS changes to the test Makefile allows the tests to pass again. The libgrok file is now also built with the correct settings.
|
The test suite is now passing, and I believe that this issue is resolved. |
|
Just confirming this has tested successfully for me. Much appreciated :) |
|
Yes, had same problem but now working. Thanks!! |
|
It does'nt work with 12.04. With Precise out, should not the test be against the gcc version used instead of the Distro version. |
|
I got the same problem but I was used an Ubuntu derivated distro which has the
#!/bin/sh
if [ "$(lsb_release -si)" = "Ubuntu" ]; then
VERSION=`lsb_release -sr`
fi
echo $VERSIONAnyway, probably is better to check the Btw, @gsandie thanks for the fix, it saved me a lot of time 😄 |
|
Yeah you're right. At the time I just went for the simplest thing that worked for me! :) I'll try and take a look at updating this commit today to something that is more portable. |
Attempted fixes for issue #8.
Created a script that will grab the ubuntu version number from the
/etc/issue file. Make changes to the Makefile so that if Ubuntu 11.10 is
detected then the gcc command string is changed to put the LDFLAGS var
at the end of the line.
Have tested on Ubuntu 10.04 and 11.10, unfortunately I have no non-ubuntu or Linux systems to hand to test with.