feat: save files in <title>.<extension> format

closes: #273

Signed-off-by: Jordan Shatford <jordanshatford@live.com>

.changeset/cold-sloths-worry.md

@@ -0,0 +1,6 @@
+---
+"@yd/extension": minor
+"@yd/web": minor
+---
+
+feat: save files in <title>.<extension> format

apps/extension/src/lib/context-service.ts

@@ -185,7 +185,7 @@ class ContextService {
 
 		const blob = await DownloadsService.getDownloadFile({ downloadId: id });
 		const download = this.#downloads[id];
-		const filename = `${download.video.title} - ${download.video.channel.name}.${download.options.format}`;
+		const filename = `${download.video.title}.${download.options.format}`;
 		try {
 			await saveAs(blob, filename);
 		} catch (e) {

apps/extension/src/lib/files.ts

@@ -8,7 +8,7 @@ export async function saveAs(blob: Blob, name: string): Promise<number> {
 	return await browser.downloads.download({
 		// Blob type and base64 data for download.
 		url: `data:${blob.type};base64,${base64}`,
-		filename: cleanFilename(name),
+		filename: name,
 		saveAs: false,
 		conflictAction: 'uniquify'
 	});
@@ -33,12 +33,3 @@ async function blobToBase64(blob: Blob): Promise<string> {
 		reader.readAsDataURL(blob);
 	});
 }
-
-/**
- * Clean a string to prevent browser download throwing invalid naming.
- * @param name - name to clean
- * @returns string - cleaned filename
- */
-function cleanFilename(name: string): string {
-	return name.replace(/[^a-z0-9]/gi, '_');
-}

apps/web/src/lib/stores/downloads.ts

@@ -85,7 +85,7 @@ function createDownloadsStore() {
 		try {
 			const blob = await DownloadsService.getDownloadFile({ downloadId: id });
 			const download = get(DOWNLOADS)[id];
-			const filename = `${download.video.title} - ${download.video.channel.name}.${download.options.format}`;
+			const filename = `${download.video.title}.${download.options.format}`;
 			saveAs(blob, filename);
 		} catch (err) {
 			handleError(id, 'Failed to get file for download.', err);