Remove std feature #9
Conversation
Thanks for this PR! I agree, we should remove the std feature entirely now; would you mind doing that in this PR? Breaking changes are ok in rustix-uring at this time. We can just release a 0.4.0 with the changes. |
|
core::time has been stable since 1.25. unfortunately, core::error has only been stable since 1.81. is 1.63 this project's MSRV? I'd like to have Error with no_std, but it doesn't look like there are nice ways of doing conditional compilation based on rustc version. I can implement it based on this suggestion it there's interest. |
|
Also, please feel free to bump the MSRV to Rust 1.81, to support |
soooch
force-pushed
the
remove-std-feature
branch
2 times, most recently
from
e3b6138 to
6efd1cf
Compare
std was used for the Error trait and Duration type, both of which are available in core.
the functionality "std" enabled in rustix-uring is now available without the "std" feature. this feature also enabled the "std" feature for the crates rustix and bitflags. downstream users of rustix-uring should explicitly enable the "std" features for those crates if needed.
breaking changes: - MSRV 1.63 -> 1.81 - "std" feature removed
soooch
force-pushed
the
remove-std-feature
branch
from
6efd1cf to
6f06234
Compare
|
This is now released in rustix-uring 0.4.0. |
|
Thanks @sunfishcode! That was crazy fast. |
2 participants
std was used for the Error trait and Duration type, both of which are available in core.
Personally I feel it would be cleaner if the std feature was removed entirely (and dependents enabled std themselves as needed for rustix and/or bitflags). It's a bit jank that we enable features we don't need. However that would be a breaking change. Also, feature deprecation is still not supported in Cargo.