Convert to TypeScript and add ESLint/Prettier #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnecessary animating happened under the Splash
Look, first real error found!
- Remove unnecessary animation props that didn't have effect and do minor animation tweaks - Remove the marquee "transition" key since it isn't a variant - Rename NavItem -> HeaderNavItem - Apply recent changes, fix comment
…lied - Also remove unnecessary props and add ones that could be needed - vercel/next.js#56511
However, what I really should do is use the "asChild" prop w/ radix-ui/react-slot
Set "react/no-unescaped-entities": "off"
Also slightly tweak some content strings
Also refactor unnecessary stuff away from useInView hook
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joonassandell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.