[5.4] Mysql installation Error Message - #46794
Merged
Merged
Conversation
This removes invalid/outdated information from the error message. It should have been removed when Joomla 4 was released as the conditions that could create the mentioned error (< php 7.4 and Mysql 8) could no longer be matched. By leaving this part of the message users are directed to an information page on the docs site with complicated instructions that are both no longer valid and very confusing and will NOT be the reason they are haviong mysql installation issues. Technically our deprecation rules for language strings would require a completely new string to be added and the code in the installer updated to use the new string and then leave this orphaned string to be removed in joomla 7. I am happy to do that but it seems a pointless exercise to me. I leave that to the maintainers to decide. Signed-off-by: BrianTeeman <brian@teeman.net>
tecpromotion
approved these changes
Jan 31, 2026
Contributor
|
Thanks @brianteeman |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46794. |
Member
|
Thanks @brianteeman for this PR, and thanks @tecpromotion for review. |
Contributor
Author
|
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
May 25, 2026
Joomla 5.4.2 joomla/joomla-cms#46583 + Joomla 5.4.3 joomla/joomla-cms#46626 + joomla/joomla-cms#46794 + joomla/joomla-cms#46716 + Joomla 5.4.4 Не было изменений Joomla 5.4.5 joomla/joomla-cms#47540 - (только для en-GB) joomla/joomla-cms#47511 + joomla/joomla-cms#47467 + Joomla 5.4.6 joomla/joomla-cms#47644 + joomla/joomla-cms#47413 + + исправления для ошибок #131 и #132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This removes invalid/outdated information from the error message. It should have been removed when Joomla 4 was released as the conditions that could create the mentioned error (< php 7.4 and Mysql 8) could no longer be matched.
By leaving this part of the message users are directed to an information page on the docs site with complicated instructions that are both no longer valid and very confusing and will NOT be the reason they are having mysql installation issues.
Technically our deprecation rules for language strings would require a completely new string to be added and the code in the installer updated to use the new string and then leave this orphaned string to be removed in joomla 7. I am happy to do that but it seems a pointless exercise to me. I leave that to the maintainers to decide.
Testing Instructions
Just code review
Actual result BEFORE applying this Pull Request
Invalid outdated information in the error message
Expected result AFTER applying this Pull Request
Only valid information in the error message
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed