[6.1] remove authentication code subject #46632
Closed
+12
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes the authentication code {CODE} from the email subject line.
What problem am I trying to solve?
The email subject line is significantly less protected than the content:
It's often displayed in plain text, for example, on smartphone lock screens, in email notifications, or previews.
This makes it much easier for others to see the subject line without opening the email (shared inbox, office, support).
Forwarding and auto-replies also pose a problem; some systems only use the subject line and reply with it again, unintentionally including the code in other emails.
Testing Instructions
Activate the MFA plugin "Multi-factor Authentication - Authentication Code by Email" and configure it for a user.
Use this login method for the user. An email will arrive in the inbox.
Actual result BEFORE applying this Pull Request
Subject e.g.: "Your 610-alpha2 authentication code is -123456-"
Expected result AFTER applying this Pull Request
Subject e.g.: "Your 610-alpha2 authentication code"
And the code is now only contained in the email body.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed