[6.1] LogTask not translated - #46375
Conversation
Some of the logTasks are translated and some are hard coded.
@brianteeman If it's a bug which affects both 5.4 and 6.0, it should be made for 5.4-dev, and if it's a bug which affects only 6.x it should be made for 6.0-dev, and if it counts as a new feature it should be made for 6.1-dev. The referred issue was flagged as bug. If you want I can ask maintainers for opinions regarding feature or not. |
|
The new language strings mean it's not something for a patch release afaik |
@brianteeman Yes, that could be, and that would mean it's for 6.1-dev. I will clarify and let you know the result. If it is good for a patch release it also can be done for 5.4-dev. |
|
btw i did try to rebase to 6.1 but it looks like 6.1 is a long way behind 6.0 at the moment so will leave it here for now |
|
@brianteeman The maintainer team has discussed and agreed that it should be made for 6.1-dev. After the next upmerge from 6.0-dev to 6.1-dev rebasing will be better. A clean rebase will not require new tests if the PR got some human tests in the meantime. |
Upmerge done (thanks @richard67 ) with PR #46384 |
|
@tecpromotion I guess you mean „done“ and not „down“. |
|
Rebased to 6.1 |
If you set it to 1 day, it still says days. But that was already the case before. |
|
I have tested this item ✅ successfully on 389e4e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375. |
1 similar comment
|
I have tested this item ✅ successfully on 389e4e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375. |
|
Thanks @brianteeman |
|
Thanks |
joomla/joomla-cms#46278 + joomla/joomla-cms#46277 + joomla/joomla-cms#46514 + joomla/joomla-cms#46375 + joomla/joomla-cms#46605 + joomla/joomla-cms#42347 + joomla/joomla-cms#47438 + (upmerge) joomla/joomla-cms#47542 + (upmerge) joomla/joomla-cms#47552 - (только для др. языков) joomla/joomla-cms#47499 - (только для en-GB) joomla/joomla-cms#47537 - (только для др. языков) joomla/joomla-cms#47229 + joomla/joomla-cms#47371 - (только для др. языков) joomla/joomla-cms#47356 + joomla/joomla-cms#47341 + joomla/joomla-cms#47290 + joomla/joomla-cms#45988 + joomla/joomla-cms#47281 - (только для др. языков) joomla/joomla-cms#47234 + joomla/joomla-cms#46438 + joomla/joomla-cms#46916 - (только для др. языков) joomla/joomla-cms#46884 + joomla/joomla-cms#46883 + joomla/joomla-cms#41927 - (только для др. языков) joomla/joomla-cms#46421 + joomla/joomla-cms#46539 + joomla/joomla-cms#46882 + joomla/joomla-cms#46786 + joomla/joomla-cms#45013 + joomla/joomla-cms#46501 + joomla/joomla-cms#46559 + joomla/joomla-cms#46820 + joomla/joomla-cms#46778 + (upmerge) joomla/joomla-cms#45990 + joomla/joomla-cms#46671 +
Pull Request for Issue #44292 .
Summary of Changes
Some of the logTasks are translated and some are hard coded.
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed