Skip to content

[6.1] LogTask not translated - #46375

Merged
tecpromotion merged 3 commits into
joomla:6.1-devfrom
brianteeman:log_task
Nov 3, 2025
Merged

[6.1] LogTask not translated#46375
tecpromotion merged 3 commits into
joomla:6.1-devfrom
brianteeman:log_task

Conversation

@brianteeman

@brianteeman brianteeman commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Pull Request for Issue #44292 .

Summary of Changes

Some of the logTasks are translated and some are hard coded.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Some of the logTasks are translated and some are hard coded.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-6.0-dev labels Oct 29, 2025
@brianteeman
brianteeman changed the base branch from 6.0-dev to 6.1-dev October 29, 2025 10:10
@brianteeman
brianteeman changed the base branch from 6.1-dev to 6.0-dev October 29, 2025 10:11
@brianteeman brianteeman changed the title [6.1] LogTask not translated [6.0] LogTask not translated Oct 29, 2025
@richard67

Copy link
Copy Markdown
Member

Not sure if this should be in 6.0 or 6.1

@brianteeman If it's a bug which affects both 5.4 and 6.0, it should be made for 5.4-dev, and if it's a bug which affects only 6.x it should be made for 6.0-dev, and if it counts as a new feature it should be made for 6.1-dev.

The referred issue was flagged as bug.

If you want I can ask maintainers for opinions regarding feature or not.

@brianteeman

Copy link
Copy Markdown
Contributor Author

The new language strings mean it's not something for a patch release afaik

@richard67

Copy link
Copy Markdown
Member

The new language strings mean it's not something for a patch release afaik

@brianteeman Yes, that could be, and that would mean it's for 6.1-dev. I will clarify and let you know the result. If it is good for a patch release it also can be done for 5.4-dev.

@brianteeman

Copy link
Copy Markdown
Contributor Author

btw i did try to rebase to 6.1 but it looks like 6.1 is a long way behind 6.0 at the moment so will leave it here for now

Comment thread administrator/language/en-GB/plg_task_updatenotification.ini Outdated
@richard67

Copy link
Copy Markdown
Member

@brianteeman The maintainer team has discussed and agreed that it should be made for 6.1-dev. After the next upmerge from 6.0-dev to 6.1-dev rebasing will be better. A clean rebase will not require new tests if the PR got some human tests in the meantime.

@tecpromotion

tecpromotion commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

@brianteeman The maintainer team has discussed and agreed that it should be made for 6.1-dev. After the next upmerge from 6.0-dev to 6.1-dev rebasing will be better. A clean rebase will not require new tests if the PR got some human tests in the meantime.

Upmerge done (thanks @richard67 ) with PR #46384

@richard67

Copy link
Copy Markdown
Member

@tecpromotion I guess you mean „done“ and not „down“.

@brianteeman
brianteeman changed the base branch from 6.0-dev to 6.1-dev October 30, 2025 18:20
@brianteeman brianteeman changed the title [6.0] LogTask not translated [6.1] LogTask not translated Oct 30, 2025
@brianteeman

Copy link
Copy Markdown
Contributor Author

Rebased to 6.1

@tecpromotion

Copy link
Copy Markdown
Contributor
#<?php die('Forbidden.'); ?>
#Date: 2025-10-31 13:27:11 UTC
#Software: Joomla! 6.0.1-dev+pr.46375 Development [ Kuimarisha ] 14-October-2025 16:01 UTC

#Fields: date	time	priority	message
2025-10-31	13:27:11	INFO	Task> Delete Logs after 1 days
2025-10-31	13:27:11	INFO	Task> Delete Logs end

If you set it to 1 day, it still says days. But that was already the case before.

@tecpromotion

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 389e4e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375.

1 similar comment
@alikon

alikon commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 389e4e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375.

@alikon

alikon commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 2, 2025
@tecpromotion
tecpromotion merged commit 1cd31e4 into joomla:6.1-dev Nov 3, 2025
42 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 3, 2025
@tecpromotion

Copy link
Copy Markdown
Contributor

Thanks @brianteeman

@brianteeman
brianteeman deleted the log_task branch November 3, 2025 17:32
@brianteeman

Copy link
Copy Markdown
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants