Skip to content

[5.4] Convert site mod_menu to service provider #45851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the site menu module to service provider.

Testing Instructions

  1. Make sure you have site module mod_menu published and configured
  2. You should see module output
mod_menu_site

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Aug 6, 2025

I have tested this item ✅ successfully on 2a88403

I have successfully tested this. Thanks @joomlaweby!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45851.

@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on 2a88403


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45851.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45851.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2025
@muhme
Copy link
Contributor

muhme commented Aug 7, 2025

Final test before merge, with JBT graft full package

  • 'Log Almost Everything' enabled
  • Created a menu with some menu entries and one sub-menu entry
  • Created menu module with new menu and placed on sidebar-right -> working on frontend site
  • Tested module options (hide title, hide sub-menu, dropdown layout) -> working
  • Seen with logged in and logout user
  • No entries in administrator/logs/*

@muhme muhme merged commit 928eaea into joomla:5.4-dev Aug 7, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 7, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 7, 2025
@muhme
Copy link
Contributor

muhme commented Aug 7, 2025

Thank you @joomlaweby for your contribution. Thank you @exlemor and @travisrisner for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants