Skip to content

[5.4] update image for "whats new tour" #45836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Aug 4, 2025

Summary of Changes

icon for automated updates was changed in #45669

Testing Instructions

update to Joomla 5.4 (eg. from 5.3)

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev labels Aug 4, 2025
@richard67
Copy link
Member

I have tested this item ✅ successfully on 393ca6c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45836.

@exlemor
Copy link

exlemor commented Aug 4, 2025

I have tested this item ✅ successfully on 393ca6c

I have tested this successfully. Updated from 5.3.2 to 5.4.0-alpha4-dev+pr.45836 package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45836.

@exlemor exlemor added the RTC This Pull Request is Ready To Commit label Aug 4, 2025
@exlemor
Copy link

exlemor commented Aug 4, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45836.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 4, 2025
@exlemor exlemor added the RTC This Pull Request is Ready To Commit label Aug 4, 2025
@muhme
Copy link
Contributor

muhme commented Aug 5, 2025

✅ Final test before merge: 5.3.3-dev update with nigthly 5.4-dev build – saw old image; with this PR's Joomla_5.4.0-alpha4-dev+pr.45836-Development-Update_Package.zip image with updated icon in different browser seen (first browser is showing persistent cached old image)

  • Note: Image is slightly increased from 774x281 to 826x300, but I assume it doesn't matter as the displayed size is variable and smaller depending on the size of the browser window

@muhme muhme merged commit f235e2f into joomla:5.4-dev Aug 5, 2025
41 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 5, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 5, 2025
@muhme
Copy link
Contributor

muhme commented Aug 5, 2025

Thank you @heelc29 for your contribution. Thank you @richard67 and @exlemor for testing.

@heelc29 heelc29 deleted the 5.4/follow-45669 branch August 7, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants