Skip to content

[5.4] Extend deprecation for editors and captcha to 7 #45819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 9, 2025

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 2, 2025

Summary of Changes

Extend deprecation for editors and captcha to 7.

Testing Instructions

Code review.

Link to documentations

Please select:

@richard67
Copy link
Member

I think we have to adapt the PHPstan baseline file as this PR here changes the deprecation doc block comments, so the PHPstan messages change, too.

Copy link
Member

@richard67 richard67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM (looks VERY good to me).

Only the removal version in deprecation comments and messages have changed from 6 to 7, and in some cases missing information about the removal version has been added to comments and messages.

The change in the phpstan-baseline.md file is correct. Only a messages has changed by adding missing information.

I think it is a good thing to have correct deprecation comments and messages already in 5.4.

@muhme
Copy link
Contributor

muhme commented Aug 9, 2025

✅ Final check before merge: Scrolled through file changes

@muhme muhme merged commit 30c09e5 into joomla:5.4-dev Aug 9, 2025
40 checks passed
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 9, 2025
@muhme
Copy link
Contributor

muhme commented Aug 9, 2025

Thank you @Fedik for your contribution.

@Fedik Fedik deleted the editor-captcha-exted-deprecation7 branch August 9, 2025 19:50
@richard67
Copy link
Member

@Fedik Do you know if we need some documentation on manual.joomla.org for this PR? If so: Could you make a PR there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants