-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.4] Extend deprecation for editors and captcha to 7 #45819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we have to adapt the PHPstan baseline file as this PR here changes the deprecation doc block comments, so the PHPstan messages change, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM (looks VERY good to me).
Only the removal version in deprecation comments and messages have changed from 6 to 7, and in some cases missing information about the removal version has been added to comments and messages.
The change in the phpstan-baseline.md file is correct. Only a messages has changed by adding missing information.
I think it is a good thing to have correct deprecation comments and messages already in 5.4.
✅ Final check before merge: Scrolled through file changes |
Thank you @Fedik for your contribution. |
@Fedik Do you know if we need some documentation on manual.joomla.org for this PR? If so: Could you make a PR there? |
Summary of Changes
Extend deprecation for editors and captcha to 7.
Testing Instructions
Code review.
Link to documentations
Please select: